Encode hostname in set_external_tags #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go code is expecting bytes, let's make sure that's what we've sent.
hithwen
reviewed
Jun 5, 2019
| @@ -333,10 +333,12 @@ def set_external_tags(self, external_tags): | |||
| # ('hostname2', {'src2_name': ['test2:t3']}) | |||
| # ] | |||
| try: | |||
| for _, source_map in external_tags: | |||
| new_tags = [] | |||
There was a problem hiding this comment.
Didnt @masci factor this out?
There was a problem hiding this comment.
We're waiting for 6.12 to release to merge it IIUC.
hithwen
approved these changes
Jun 5, 2019
ofek
pushed a commit
that referenced
this pull request
Jun 5, 2019
The go code is expecting bytes, let's make sure that's what we send.
ofek
pushed a commit
that referenced
this pull request
Jun 21, 2019
* remove duplicated code * fix property signature * reuse more code with to_string * change property into constant * use plain empty string * move 'normalize' to the base class * style fix * moved docs over from datadog-agent * avoid deleting the class object so Sphinx can parse it * style fix * add .base. to the module path * update from #3866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go code is expecting bytes, let's make sure that's what we send.