Revert "[prometheus check] Actually use provided "metrics_mapper" (#3… #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 176b71d.
ofek
approved these changes
Jun 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
- Coverage 86.82% 84.15% -2.68%
==========================================
Files 729 62 -667
Lines 37220 4884 -32336
Branches 4350 596 -3754
==========================================
- Hits 32316 4110 -28206
+ Misses 3744 643 -3101
+ Partials 1160 131 -1029 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
- Coverage 86.82% 84.15% -2.68%
==========================================
Files 729 62 -667
Lines 37220 4884 -32336
Branches 4350 596 -3754
==========================================
- Hits 32316 4110 -28206
+ Misses 3744 643 -3101
+ Partials 1160 131 -1029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper way to change a metric name is by setting up the optional <NEW_METRIC_NAME> field in the metrics param.