Add upper_bound tag for the total count when collecting histograms buckets #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfpierre
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
=========================================
- Coverage 86.79% 84.1% -2.69%
=========================================
Files 729 62 -667
Lines 37019 4826 -32193
Branches 4325 590 -3735
=========================================
- Hits 32129 4059 -28070
+ Misses 3736 638 -3098
+ Partials 1154 129 -1025 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
=========================================
- Coverage 86.79% 84.1% -2.69%
=========================================
Files 729 62 -667
Lines 37019 4826 -32193
Branches 4325 590 -3735
=========================================
- Hits 32129 4059 -28070
+ Misses 3736 638 -3098
+ Partials 1154 129 -1025 |
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
=========================================
- Coverage 86.48% 84.1% -2.38%
=========================================
Files 730 62 -668
Lines 37833 4826 -33007
Branches 4521 590 -3931
=========================================
- Hits 32720 4059 -28661
+ Misses 3877 638 -3239
+ Partials 1236 129 -1107 |
xlucas
reviewed
May 16, 2019
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
ofek
previously requested changes
May 16, 2019
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
mfpierre
force-pushed
the
mfpierre/fix-total-histogram-count
branch
2 times, most recently
from
3751ecf
to
450db5a
Compare
mfpierre
force-pushed
the
mfpierre/fix-total-histogram-count
branch
from
450db5a
to
ace0b50
Compare
hkaj
approved these changes
May 20, 2019
xlucas
approved these changes
May 20, 2019
hithwen
approved these changes
May 21, 2019
mfpierre
added a commit
that referenced
this pull request
May 31, 2019
…ckets (#3777) * Add upper_bound tag for the total count when collecting histograms bucket * Use append instead of + operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
send_histograms_bucketsis activated buckets are send addingupper_boundtag to the*.countmetrics. The issue is the total count which does not include any tag is not queryable.This PR add the tag
upper_bound:noneto properly query it along with buckets.Motivation
Fix querying the total count on Datadog when collecting buckets
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached