Add easier namespacing for data submission #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3718 +/- ##
==========================================
- Coverage 86.49% 84.08% -2.41%
==========================================
Files 727 62 -665
Lines 37544 4732 -32812
Branches 4481 578 -3903
==========================================
- Hits 32474 3979 -28495
+ Misses 3849 632 -3217
+ Partials 1221 121 -1100 |
masci
approved these changes
May 6, 2019
zippolyte
approved these changes
May 6, 2019
truthbk
approved these changes
May 6, 2019
| if event.get('tags'): | ||
| event['tags'] = self._normalize_tags_type(event['tags']) | ||
| if event.get('timestamp'): | ||
| event['timestamp'] = int(event['timestamp']) | ||
| if event.get('aggregation_key'): | ||
| event['aggregation_key'] = ensure_unicode(event['aggregation_key']) | ||
|
|
||
| if self.__NAMESPACE__: | ||
| event.setdefault('source_type_name', self.__NAMESPACE__) |
There was a problem hiding this comment.
This is the only bit that would introduce a change in behavior. I don't really object to it, it's just worth noting.
| if event.get('tags'): | ||
| event['tags'] = self._normalize_tags_type(event['tags']) | ||
| if event.get('timestamp'): | ||
| event['timestamp'] = int(event['timestamp']) | ||
| if event.get('aggregation_key'): | ||
| event['aggregation_key'] = ensure_bytes(event['aggregation_key']) | ||
|
|
||
| if self.__NAMESPACE__: | ||
| event.setdefault('source_type_name', self.__NAMESPACE__) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the need to perform string formatting throughout every check, see for example
integrations-core/ibm_db2/datadog_checks/ibm_db2/ibm_db2.py
Line 85 in d3931ad
I'll be using this for the integration I'm currently working on