Improve resiliency of logging initialization phase #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
requested changes
May 2, 2019
therve
requested changes
May 2, 2019
| if PY2 and isinstance(lvl, text_type): | ||
| try: | ||
| lvl = lvl.encode('utf-8') | ||
| except UnicodeError: |
There was a problem hiding this comment.
If we're going to catch that, we may as well pass errors="ignore" to the encode call.
There was a problem hiding this comment.
right, even better at this point would be using ascii
| # default value for invalid input | ||
| assert log._get_py_loglevel(None) == logging.INFO | ||
| # default value for invalid unicode input | ||
| assert log._get_py_loglevel(u'dèbùg') == logging.INFO |
There was a problem hiding this comment.
AFAIK this is valid utf-8 input, so it's encoded properly. I guess we need so weirder string to test it?
There was a problem hiding this comment.
the intention was to test a proper encoding but into a key that's invalid
Codecov Report
@@ Coverage Diff @@
## master #3705 +/- ##
==========================================
- Coverage 86.42% 83.96% -2.46%
==========================================
Files 730 62 -668
Lines 37041 4702 -32339
Branches 4360 574 -3786
==========================================
- Hits 32012 3948 -28064
+ Misses 3855 633 -3222
+ Partials 1174 121 -1053 |
zippolyte
approved these changes
May 2, 2019
therve
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached