Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ship pyodbc on macOS as SQLServer integration is not shipped on macOS #3461

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

arbll
Copy link
Member

@arbll arbll commented Apr 4, 2019

What does this PR do?

Avoid trying to install pyodbc on darwin.

Motivation

It fails on darwin since no pre-built wheels are available for our builder os version.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #3461 into master will decrease coverage by 4.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3461      +/-   ##
==========================================
- Coverage   86.29%   81.51%   -4.78%     
==========================================
  Files         740       69     -671     
  Lines       38558     5427   -33131     
  Branches     4585      688    -3897     
==========================================
- Hits        33272     4424   -28848     
+ Misses       4018      834    -3184     
+ Partials     1268      169    -1099

olivielpeau
olivielpeau previously approved these changes Apr 4, 2019
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add that to the agent requirements in datadog_checks_base as well. A ddev dep freeze should do that for you.

@arbll arbll requested review from a team as code owners April 4, 2019 18:05
@arbll arbll requested a review from zippolyte April 4, 2019 18:27
@zippolyte zippolyte changed the title avoid installing pyodbc on darwin Don't ship pyodbc on macOS as SQLServer integration is not shipped on macOS Apr 4, 2019
@zippolyte zippolyte merged commit d165455 into master Apr 4, 2019
@zippolyte zippolyte deleted the arbll/sqlserver-disable-darwin branch April 4, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants