Parse timeouts as floats in RequestsWrapper #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
==========================================
- Coverage 86.46% 83.87% -2.6%
==========================================
Files 735 62 -673
Lines 37955 4694 -33261
Branches 4461 574 -3887
==========================================
- Hits 32819 3937 -28882
+ Misses 3936 636 -3300
+ Partials 1200 121 -1079 |
hithwen
approved these changes
Apr 3, 2019
| check = AgentCheck('test', {}, [{}]) | ||
|
|
||
| assert check.http == check._http | ||
| assert isinstance(check.http, RequestsWrapper) | ||
|
|
||
| def test_remapper_no_trigger(self): |
There was a problem hiding this comment.
I assume this test was not necessary before the change
|
Does this need to be in 6.11 ? |
|
No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
No precision loss
Additional Notes
Also cleaned up a test that no longer is necessary