Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #3425

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Support Python 3 #3425

merged 1 commit into from
Mar 29, 2019

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Supporting python3 for dns_check. The package dnspython v1.16 we use should support python 3.

Motivation

Additional Notes

It has already been try in #2733

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #3425 into master will increase coverage by 5.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #3425     +/-   ##
=========================================
+ Coverage   79.04%   84.15%   +5.1%     
=========================================
  Files         155       70     -85     
  Lines        7789     4917   -2872     
  Branches      948      598    -350     
=========================================
- Hits         6157     4138   -2019     
+ Misses       1409      650    -759     
+ Partials      223      129     -94

Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings with numbered placeholders (eg: "{0}") should still work with format in python3, so I don't see the need to replace them. In any case, it's not a problem since we don't need to translate these strings. LGTM.

@zippolyte zippolyte changed the title Support python 3 for dns_check Support python 3 Mar 29, 2019
@zippolyte zippolyte changed the title Support python 3 Support Python 3 Mar 29, 2019
@coignetp coignetp merged commit a149c7f into master Mar 29, 2019
@coignetp coignetp deleted the paul/py3-dns branch March 29, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants