Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade in-toto #3411

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Upgrade in-toto #3411

merged 3 commits into from
Mar 29, 2019

Conversation

trishankatdatadog
Copy link
Member

What does this PR do?

Update in-toto in downloader and ddev from 0.2.3 to 0.3.0.

Motivation

Much better error messages for users and ourselves for When Things Go Wrong.

Additional Notes

@ofek should check to make sure that ddev continues to work as expected on Windows.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #3411 into master will decrease coverage by 3.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3411      +/-   ##
==========================================
- Coverage   86.03%   82.77%   -3.27%     
==========================================
  Files         720       99     -621     
  Lines       38209     5949   -32260     
  Branches     4643      687    -3956     
==========================================
- Hits        32873     4924   -27949     
+ Misses       4071      862    -3209     
+ Partials     1265      163    -1102

@ofek ofek changed the title Update in-toto Upgrade in-toto Mar 27, 2019
ofek
ofek previously approved these changes Mar 27, 2019
@ofek ofek requested a review from a team as a code owner March 28, 2019 13:45
@trishankatdatadog
Copy link
Member Author

Good catch @ofek 🙇

@zippolyte zippolyte merged commit af6acb4 into master Mar 29, 2019
@zippolyte zippolyte deleted the trishankatdatadog/update-in-toto branch March 29, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants