Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never chdir back to a directory we don't control #3282

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

trishankatdatadog
Copy link
Member

What does this PR do?

Removes the need to change to directories we don't control.

Motivation

Remove the need for the Agent to be aware about switching directories at all.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@trishankatdatadog
Copy link
Member Author

@lukpueh @SantiagoTorres Makes sense?

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3282 into master will decrease coverage by 6.57%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   85.11%   78.54%   -6.58%     
==========================================
  Files         707        8     -699     
  Lines       38227      233   -37994     
  Branches     4673       22    -4651     
==========================================
- Hits        32537      183   -32354     
+ Misses       4401       38    -4363     
+ Partials     1289       12    -1277

@SantiagoTorres
Copy link

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants