Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade protobuf to 3.7.0 #3272

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Upgrade protobuf to 3.7.0 #3272

merged 1 commit into from
Mar 10, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 9, 2019

@ofek ofek requested review from a team as code owners March 9, 2019 06:03
@codecov
Copy link

codecov bot commented Mar 9, 2019 •
edited
Loading

Codecov Report

Merging #3272 into master will increase coverage by 8.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
+ Coverage   75.92%   84.88%   +8.95%     
==========================================
  Files          54      707     +653     
  Lines        3980    39418   +35438     
  Branches      509     4873    +4364     
==========================================
+ Hits         3022    33460   +30438     
- Misses        839     4591    +3752     
- Partials      119     1367    +1248

gzussa
gzussa previously approved these changes Mar 10, 2019
View reviewed changes
@ofek ofek merged commit 6e323b0 into master Mar 10, 2019
@ofek ofek deleted the ofek/up branch March 10, 2019 19:26
@olivielpeau
Copy link
Member

same as the requests bump, this is also used in Agent 5 so requires a bump in these 2 locations:

This was referenced Mar 11, 2019
Merged
Merged
@olivielpeau olivielpeau mentioned this pull request Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa left review comments

Assignees
No one assigned
Labels
integration/datadog_checks_base integration/gitlab_runner integration/gitlab integration/kube_dns integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @olivielpeau @gzussa