Collect PodDisruptionBudget metrics #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3111 +/- ##
==========================================
- Coverage 84.83% 81.86% -2.97%
==========================================
Files 681 4 -677
Lines 35675 353 -35322
Branches 4285 68 -4217
==========================================
- Hits 30265 289 -29976
+ Misses 4153 44 -4109
+ Partials 1257 20 -1237 |
|
Do you have a rough estimate of when this feature might make it into an agent release? We're trying to weigh options for using a custom solution or waiting for native integration. Thanks! |
xvello
reviewed
Feb 14, 2019
kubernetes_state/metadata.csv
Outdated
| kubernetes_state.pdb.pods_desired,gauge,,,,Minimum desired number of healthy pods,0,kubernetes,k8s_state.pdb.pods_desired | ||
| kubernetes_state.pdb.disruptions_allowed,gauge,,,,Number of pod disruptions that are currently allowed,0,kubernetes,k8s_state.pdb.disruptions_allowed | ||
| kubernetes_state.pdb.pods_healthy,gauge,,,,Current number of healthy pods,0,kubernetes,k8s_state.pdb.pods_healthy | ||
| kubernetes_state.pdb.pods,gauge,,,,Total number of pods counted by this disruption budget,0,kubernetes,k8s_state.pdb.pods |
There was a problem hiding this comment.
Would it make sense to rename it .pdb.pods_total for consistency with the other gauges, and being more explicit?
There was a problem hiding this comment.
I concur as it would also be consistent with what one sees when using kubectl describe pdb ....
|
@bgeesaman This should be in 6.10. Our target date for this release is week 9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Collect the following gauges reporting information about PodDisruptionBudget objects:
Motivation
Allow tracking PDB information.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?