Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __main__ module to package #3108

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Add __main__ module to package #3108

merged 1 commit into from
Feb 13, 2019

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Feb 13, 2019

What does this PR do?

Add __main__ module to package, so that it can be executed with python -m datadog_checks.downloader datadog-vsphere

Motivation

Needed for windows so that the integration command can use the downloader

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #3108 into master will increase coverage by 15.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #3108       +/-   ##
==========================================
+ Coverage   84.97%    100%   +15.02%     
==========================================
  Files         676       1      -675     
  Lines       34940      18    -34922     
  Branches     4188       2     -4186     
==========================================
- Hits        29689      18    -29671     
+ Misses       4032       0     -4032     
+ Partials     1219       0     -1219

@zippolyte zippolyte merged commit bcdd6c5 into master Feb 13, 2019
@zippolyte zippolyte deleted the hippo/downloader_main branch February 13, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants