Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports Python3 for the base classes of the WMI check
The biggest change here is the way the metaclass is defined. In Python3, you can no longer do the metaclass approach and need to put it in the declaration of the class itself. Six provides a way to be compatible with both, so I used that.
PEP that changes this - https://www.python.org/dev/peps/pep-3115/
Also,
map
was returning the map type, so you couldn't add a map to a list, this casts the map to the underlying type of list.Motivation
🐍3️⃣
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?