-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix riakcs dependencies #3033
Fix riakcs dependencies #3033
Conversation
34634d0
to
3ae95d8
Compare
706b4fc
to
5b17d91
Compare
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
==========================================
- Coverage 83.87% 75.98% -7.9%
==========================================
Files 679 52 -627
Lines 37291 3722 -33569
Branches 4469 444 -4025
==========================================
- Hits 31277 2828 -28449
+ Misses 4728 780 -3948
+ Partials 1286 114 -1172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for cleaning this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, otherwise looks good. Thank a lot!
@@ -2,18 +2,18 @@ | |||
minversion = 2.0 | |||
basepython = py27 | |||
envlist = | |||
{py27,py36}-unit | |||
py{27,36}-unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it as py27,py36
, I am applying the same logic on all tox files in another PR and I choose the former wat just because there are less of the later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe could we change the other pr? I think this is more standard in other projects it seems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Motivation
Completes #2800
Notes
Also removed