Fix riakcs dependencies #3033
Merged
Fix riakcs dependencies #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
force-pushed
the
ofek/riak
branch
2 times, most recently
from
34634d0
to
3ae95d8
Compare
zippolyte
previously approved these changes
Jan 25, 2019
ofek
force-pushed
the
ofek/riak
branch
6 times, most recently
from
706b4fc
to
5b17d91
Compare
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
==========================================
- Coverage 83.87% 75.98% -7.9%
==========================================
Files 679 52 -627
Lines 37291 3722 -33569
Branches 4469 444 -4025
==========================================
- Hits 31277 2828 -28449
+ Misses 4728 780 -3948
+ Partials 1286 114 -1172 |
ofek
added
integration/datadog_checks_base
changelog/Changed
and removed
changelog/no-changelog
labels
nmuesch
approved these changes
Jan 26, 2019
gzussa
suggested changes
Jan 28, 2019
| @@ -2,18 +2,18 @@ | |||
| minversion = 2.0 | |||
| basepython = py27 | |||
| envlist = | |||
| {py27,py36}-unit | |||
| py{27,36}-unit | |||
There was a problem hiding this comment.
Let's keep it as py27,py36, I am applying the same logic on all tox files in another PR and I choose the former wat just because there are less of the later
There was a problem hiding this comment.
Maybe could we change the other pr? I think this is more standard in other projects it seems
gzussa
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Completes #2800
Notes
Also removed