Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #3030

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Support Python 3 #3030

merged 1 commit into from
Jan 25, 2019

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jan 24, 2019

What does this PR do?

Adds Python 3 support by changing iteritems, and lightly ensuring unicode in the tests.

Motivation

🐍 3️⃣

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #3030 into master will decrease coverage by 2.28%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
- Coverage   84.15%   81.86%   -2.29%     
==========================================
  Files         673        4     -669     
  Lines       36595      353   -36242     
  Branches     4336       68    -4268     
==========================================
- Hits        30798      289   -30509     
+ Misses       4548       44    -4504     
+ Partials     1249       20    -1229

@nmuesch nmuesch merged commit 9ef9994 into master Jan 25, 2019
@gzussa gzussa deleted the nick/kubernetes_state branch January 28, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants