Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log messages for when tags aren't utf-8 #2966

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Improve log messages for when tags aren't utf-8 #2966

merged 2 commits into from
Jan 17, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 17, 2019

Motivation

Better insight into where the tag came from

@codecov-io
Copy link

Codecov Report

Merging #2966 into master will decrease coverage by 9.3%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
- Coverage   84.79%   75.48%   -9.31%     
==========================================
  Files         654       46     -608     
  Lines       36319     3573   -32746     
  Branches     4334      427    -3907     
==========================================
- Hits        30795     2697   -28098     
+ Misses       4262      767    -3495     
+ Partials     1262      109    -1153

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2966 into master will decrease coverage by 9.3%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
- Coverage   84.79%   75.48%   -9.31%     
==========================================
  Files         654       46     -608     
  Lines       36319     3573   -32746     
  Branches     4334      427    -3907     
==========================================
- Hits        30795     2697   -28098     
+ Misses       4262      767    -3495     
+ Partials     1262      109    -1153

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofek ofek merged commit 46d5b9f into master Jan 17, 2019
@ofek ofek deleted the ofek/t branch January 17, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants