Make service check statuses available as constants

[ofek]

Motivation

Easier access for utility functions that map product statuses to service check statuses

[codecov-io]

Codecov Report

Merging #2960 into master will decrease coverage by 0.29%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #2960     +/-   ##
=========================================
- Coverage   84.86%   84.56%   -0.3%     
=========================================
  Files         652      663     +11     
  Lines       36125    38139   +2014     
  Branches     4292     4559    +267     
=========================================
+ Hits        30656    32253   +1597     
- Misses       4203     4538    +335     
- Partials     1266     1348     +82

[gmmeyer]

why move this to a new file?

[ofek]

Well it's a constant so it makes sense. Also there are others below like ONE_PER_CONTEXT_METRIC_TYPES that we should eventually move there as well

[gzussa]

Being able to access them from base seems very handy.

[gmmeyer]

Yea, that makes sense. But since these all still need to be members of the class it would just cut down on duplication in the AgentCheck classes, I suppose

[nmuesch]

Looks good to me. Thanks

[gmmeyer]

Can you elaborate on what change you're planning on making that will rely upon this? I don't dislike this, I just wanna know the context

[gzussa]

Actually I think @gmmeyer comment is very relevant here.

[ofek]

@gmmeyer

<CHECK>/utils.py

from datadog_checks.base.constants import ServiceCheck


def product_state_to_service_check(state):
    if state == 'ACTIVE':
        return ServiceCheck.OK
    ....

[gmmeyer]

Is there a check you want to use this in now?

[ofek]

Yes, ibm_db2