Support Python 3 #2833
Merged
Support Python 3 #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2833 +/- ##
==========================================
+ Coverage 84.69% 88.54% +3.85%
==========================================
Files 662 7 -655
Lines 37611 262 -37349
Branches 4507 40 -4467
==========================================
- Hits 31853 232 -31621
+ Misses 4436 19 -4417
+ Partials 1322 11 -1311 |
nmuesch
requested changes
Dec 26, 2018
| import requests | ||
|
|
||
| # project | ||
| from six.moves.urllib.parse import urlparse | ||
|
|
There was a problem hiding this comment.
Small nit, but looks like an extra newline here.
| @@ -72,14 +73,15 @@ def _get_data(self, url, instance): | |||
| 'ssl_certfile': instance.get('ssl_certfile'), | |||
| 'ssl_verify': instance.get('ssl_verify'), | |||
| } | |||
| for key, param in ssl_params.items(): | |||
| ssl_params_copy = copy.copy(ssl_params) | |||
| for key, param in iteritems(ssl_params_copy): | |||
There was a problem hiding this comment.
Suggested change
| for key, param in iteritems(ssl_params_copy): | |
| for key, param in list(iteritems(ssl_params)): |
We could remove the copy line then. Using list() is supposed to be slightly faster as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves GoExpvar to Python3! This one was a straightforward one. I was worried about that, but it seems like the string manipulation issues are mostly handled in this one.
Motivation
🐍 3️⃣ 🚂
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?