Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #2786

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Support Python 3 #2786

merged 2 commits into from
Dec 18, 2018

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Dec 18, 2018

What does this PR do?

Add support for Python3

Motivation

An effort to make all checks support Py2/3

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2786 into master will increase coverage by 3.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2786      +/-   ##
==========================================
+ Coverage    84.8%   88.13%   +3.33%     
==========================================
  Files         658        6     -652     
  Lines       37540      295   -37245     
  Branches     4504       44    -4460     
==========================================
- Hits        31834      260   -31574     
+ Misses       4391       19    -4372     
+ Partials     1315       16    -1299

@nmuesch nmuesch merged commit b1cf1a8 into master Dec 18, 2018
@nmuesch nmuesch deleted the nick/yarn3 branch December 18, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants