Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3 #2783

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Support Python 3 #2783

merged 1 commit into from
Dec 20, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Dec 18, 2018 •
edited
Loading

Motivation

Also added e2e

Additional Notes

Depends on #2784

@ofek ofek requested a review from a team as a code owner December 18, 2018 06:31
gmmeyer
gmmeyer approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, one small question

mcache/datadog_checks/mcache/mcache.py Show resolved Hide resolved
@ofek ofek merged commit 6d43f74 into master Dec 20, 2018
@ofek ofek deleted the ofek/mcache branch December 20, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
dev/testing integration/mcache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @gmmeyer @gzussa