Add support for database metrics #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2777 +/- ##
===========================================
- Coverage 84.75% 73.54% -11.21%
===========================================
Files 657 6 -651
Lines 37463 223 -37240
Branches 4502 26 -4476
===========================================
- Hits 31750 164 -31586
+ Misses 4397 42 -4355
+ Partials 1316 17 -1299 |
|
What do I have to do to get this simple change merged? |
ofek
approved these changes
Jan 28, 2019
ofek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds per database metrics to the pgBouncer check.
See SHOW DATABASES on https://pgbouncer.github.io/usage.html
Motivation
These metrics are vital for monitoring pgBouncer, especially when having more than one database configured in one instance.