-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3 #2738
Support Python 3 #2738
Conversation
--hash=sha256:2b1876a60e32e24bed4c6d187898274de6409bbfa942bcbe3512efdf2aed0ec9 | ||
|
||
python3-gearman==0.1.0 ; sys_platform != "win32" and python_version > "3.0" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we bumping the req in the root agent-req file now or when release happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it now pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmuesch I bumped the requirements file, can you rereview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks. Left a quick question but approving, lets just wait for CI to be green.
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
==========================================
- Coverage 84.7% 75.83% -8.87%
==========================================
Files 657 51 -606
Lines 37189 3398 -33791
Branches 4462 395 -4067
==========================================
- Hits 31501 2577 -28924
+ Misses 4378 718 -3660
+ Partials 1310 103 -1207 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
What does this PR do?
This moves Gearmand to Python3. Python 3 support for the library is a new drop in replacement library: https://github.com/josiahmwalton/python3-gearman
We can use that, we just need to amend the requirements files and make the import conditional
Motivation
We need to move everything to python3
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?