Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unicode for subprocess output #2697

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Dec 5, 2018

What does this PR do?

Runs ensure_unicode on the result of get_subprocess_output before returning it.

Motivation

When porting checks to Python3, we do a lot of literal string comparison between some hardcoded expected strings and the output from get_subprocess_output. Due to this and other similar scenarios, its expected/required that the output from get_subprocess_output is an appropriate non bytes format. This uses the ensure_unicode helper function to perform this action for us.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

@nmuesch nmuesch requested a review from a team as a code owner December 5, 2018 22:41
@nmuesch nmuesch mentioned this pull request Dec 5, 2018
4 tasks
@nmuesch nmuesch merged commit 4087d89 into master Dec 6, 2018
@nmuesch nmuesch deleted the nick/subprocess_unicode branch December 6, 2018 21:05
ofek pushed a commit that referenced this pull request Dec 7, 2018
* Ensure unicode for subprocess output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants