Ensure unicode for subprocess output #2697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Runs
ensure_unicode
on the result of get_subprocess_output before returning it.Motivation
When porting checks to Python3, we do a lot of literal string comparison between some hardcoded expected strings and the output from get_subprocess_output. Due to this and other similar scenarios, its expected/required that the output from get_subprocess_output is an appropriate non
bytes
format. This uses theensure_unicode
helper function to perform this action for us.Review checklist
no-changelog
label attachedAdditional Notes