Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #2630

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Support Python 3 #2630

merged 1 commit into from
Nov 23, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Nov 22, 2018

Additional Notes

Also added e2e

@codecov-io
Copy link

codecov-io commented Nov 22, 2018

Codecov Report

Merging #2630 into master will decrease coverage by 7.92%.
The diff coverage is 89.79%.

@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   83.89%   75.96%   -7.93%     
==========================================
  Files         644        8     -636     
  Lines       36469      882   -35587     
  Branches     4439      184    -4255     
==========================================
- Hits        30595      670   -29925     
+ Misses       4560      135    -4425     
+ Partials     1314       77    -1237

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ofek ofek merged commit 4eadfa2 into master Nov 23, 2018
@ofek ofek deleted the ofek/mp branch November 23, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants