Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to send additional metric tags for Open Metrics #2514

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Nov 6, 2018

Motivation

Often need to send more than user-defined custom_tags

@ofek ofek changed the title Add health check tags option for Open Metrics Add option to send additional metric tags for Open Metrics Nov 6, 2018
Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though can we get a review from @DataDog/container-integrations as well?

@mfpierre
Copy link
Contributor

mfpierre commented Nov 7, 2018

I'm not sure I get the difference between custom_tags and _metric_tags, what's the need?

Is this setting used in some other checks?

@zippolyte
Copy link
Contributor

custom_tags are user defined tags in the configuration file of the check. They should not be modified by the check to pass in metric tags, hence the need of an additional field.
This is particularly important in the case of the etcd check (v3 uses openmetrics), because we tag service checks with custom tags defined by the user, and we don't want the metric tags to be associated with them.

@ofek ofek merged commit 34bf1e7 into master Nov 7, 2018
@ofek ofek deleted the ofek/omhct branch November 7, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants