Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated agentConfig option locations #2488

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Removed deprecated agentConfig option locations #2488

merged 1 commit into from
Oct 30, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 29, 2018

Motivation

They were actually intended to be removed in 6.0

@codecov-io
Copy link

Codecov Report

Merging #2488 into master will increase coverage by 7.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   84.53%   91.79%   +7.26%     
==========================================
  Files         626       10     -616     
  Lines       35160      378   -34782     
  Branches     4282       49    -4233     
==========================================
- Hits        29723      347   -29376     
+ Misses       4148       25    -4123     
+ Partials     1289        6    -1283

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ofek ofek merged commit 591525a into master Oct 30, 2018
@ofek ofek deleted the ofek/d branch October 30, 2018 14:09
@gzussa gzussa mentioned this pull request Jan 2, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants