Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KSM deprecation warning on A5 #2317

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Conversation

mfpierre
Copy link
Contributor

What does this PR do?

Fix the use of a deprecation method only compatible with A6

Motivation

Make the KSM check work again on A5

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Is it ok to call self.warning in the init function?

@mfpierre mfpierre requested a review from a team September 28, 2018 17:34
@mfpierre mfpierre requested a review from a team as a code owner September 28, 2018 17:34
@mfpierre mfpierre removed the request for review from a team September 28, 2018 17:39
@codecov-io
Copy link

Codecov Report

Merging #2317 into master will decrease coverage by 3.21%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   85.83%   82.62%   -3.22%     
==========================================
  Files         188        4     -184     
  Lines       12676      374   -12302     
  Branches     1324       72    -1252     
==========================================
- Hits        10881      309   -10572     
+ Misses       1410       44    -1366     
+ Partials      385       21     -364
Flag Coverage Δ
#activemq_xml ?
#agent_metrics ?
#apache ?
#btrfs ?
#cacti ?
#cassandra_nodetool ?
#ceph ?
#cisco_aci ?
#cockroachdb ?
#consul ?
#couch ?
#couchbase ?
#datadog_checks_base ?
#datadog_checks_dev ?
#directory ?
#disk ?
#dns_check ?
#ecs_fargate ?
#envoy ?
#etcd ?
#fluentd ?
#gearmand ?
#go_expvar ?
#gunicorn ?
#hdfs_datanode ?
#hdfs_namenode ?
#http_check ?
#istio ?
#kube_dns ?
#kube_proxy ?
#kubernetes_state 82.62% <50%> (?)

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

"`send_pod_phase_service_checks` to false and rely on corresponding gauges instead",
]
if self.send_pod_phase_service_checks:
self.warning("DEPRECATION NOTICE: pod phase service checks are deprecated. Please set "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling instance methods like warning in the __init__ could be risky if the object weren't properly initialized... However at this stage, after the super(), this doesn't look too harmful to me. Also, the constructor is unlikely to fail after the warning.

@truthbk truthbk merged commit 8abd626 into master Sep 28, 2018
@truthbk truthbk deleted the mfpierre/fix-ksm-A5-deprecation branch September 28, 2018 19:26
ofek pushed a commit that referenced this pull request Sep 28, 2018
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants