Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch implementation logic #2265

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Fix batch implementation logic #2265

merged 2 commits into from
Sep 19, 2018

Conversation

zippolyte
Copy link
Contributor

What does this PR do?

Fixes the batch implementation logic. Before this fix, we didn't reset the query_spec object at each loop run, so we ended up doing total_nb_objects / batch_size requests, each querying metrics for every objects instead of just the objects of the batch.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2265 into master will decrease coverage by 4.48%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage    86.1%   81.62%   -4.49%     
==========================================
  Files         189       15     -174     
  Lines       13639     1219   -12420     
  Branches     1442      134    -1308     
==========================================
- Hits        11744      995   -10749     
+ Misses       1488      193    -1295     
+ Partials      407       31     -376

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zippolyte zippolyte merged commit 23e7e51 into master Sep 19, 2018
@zippolyte zippolyte deleted the hippo/vsphere_fix branch September 19, 2018 08:39
zippolyte added a commit that referenced this pull request Sep 19, 2018
taylor-chen pushed a commit that referenced this pull request Sep 19, 2018
taylor-chen pushed a commit that referenced this pull request Sep 19, 2018
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants