Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default prometheus metric limit to 2000 #2248

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Sep 17, 2018

What does this PR do?

Partial revert of #2214 (keeping the wording changes).
Set the default prometheus metric limit to 2000 for 6.6 (was 250k for 6.5)

@codecov-io
Copy link

Codecov Report

Merging #2248 into master will decrease coverage by 16.12%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #2248       +/-   ##
===========================================
- Coverage    86.1%   69.98%   -16.13%     
===========================================
  Files         197       37      -160     
  Lines       13821     2319    -11502     
  Branches     1469      343     -1126     
===========================================
- Hits        11901     1623    -10278     
+ Misses       1501      614      -887     
+ Partials      419       82      -337

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xvello xvello merged commit be41880 into master Sep 17, 2018
@xvello xvello deleted the xvello/prom2000 branch September 17, 2018 15:41
@ofek ofek changed the title Revert default prometheus metric limit to 2000 Change default prometheus metric limit to 2000 Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants