Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prometheus scraping for Python 3 #2128

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Fix Prometheus scraping for Python 3 #2128

merged 1 commit into from
Aug 29, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 29, 2018

Motivation

        for line in fd:                                                               
            line = line.strip()                                                       
                                                                                      
>           if line.startswith('#'):                                                  
E           TypeError: startswith first arg must be bytes or a tuple of bytes, not str
                                                                                      
.tox\py36-cockroachdb\lib\site-packages\prometheus_client\parser.py:138: TypeError    

Additional Notes

We do the same thing here https://github.com/DataDog/integrations-core/pull/2117/files#diff-4e5d5c986dbd1ca04f508a0cd7f1c8e5R40

@codecov-io
Copy link

Codecov Report

Merging #2128 into master will decrease coverage by 13.73%.
The diff coverage is 100%.

Impacted file tree graph

@rishabh rishabh merged commit 11bbf30 into master Aug 29, 2018
@ofek ofek deleted the ofek/fix-prom branch August 29, 2018 16:05
shraykay pushed a commit to shraykay/integrations-core that referenced this pull request Aug 30, 2018
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants