-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change boolean values in config from yes/no to true/false #2078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me. However, make sure it is safe to do so in the code (good use of is_affirmative
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Not sure what the reviews mean: did anybody check we're making good use of |
As |
Thanks @arbll ! |
What does this PR do?
Changes all boolean values in agent 6 config files from
yes
/no
totrue
/false
.Motivation
Sister of DataDog/datadog-agent#2171
Main goal was to avoid confusion when using environment variable instead of config files as
yes
/no
is not supported in that case.Review checklist
no-changelog
label attached