Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ContainerCreating in pod waiting status reasons #2063

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Include ContainerCreating in pod waiting status reasons #2063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44b6b31
Document distinction in seeming duplication
deiwin Aug 16, 2018
b8ca252
Include ContainerCreating in k8s pod waiting status reasons
deiwin Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
METRIC_TYPES = ['counter', 'gauge']

# As case can vary depending on Kubernetes versions, we match the lowercase string
WHITELISTED_WAITING_REASONS = ['errimagepull', 'imagepullbackoff', 'crashloopbackoff']
WHITELISTED_WAITING_REASONS = ['errimagepull', 'imagepullbackoff', 'crashloopbackoff', 'containercreating']
WHITELISTED_TERMINATED_REASONS = ['oomkilled', 'containercannotrun', 'error']


Expand Down
5 changes: 3 additions & 2 deletions kubernetes_state/tests/test_kubernetes_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,9 @@
'namespace:kube-system'
],
NAMESPACE + '.container.status_report.count.waiting': [
'reason:CrashLoopBackoff',
'reason:CrashLoopBackOff',
'reason:ContainerCreating',
'reason:CrashLoopBackoff', # Lowercase "off"
'reason:CrashLoopBackOff', # Uppercase "Off"
'reason:ErrImagePull',
'reason:ImagePullBackoff'
]
Expand Down