Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly skip proxy environment variables #1935

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Properly skip proxy environment variables #1935

merged 1 commit into from
Jul 24, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 24, 2018

Motivation

This makes it so the returned dict will instruct requests to ignore the HTTP_PROXY/HTTPS_PROXY environment variables. If the proxy options http/https are missing or are None then requests will use the aforementioned environment variables, hence the need to set each to an empty string.

@ofek ofek requested a review from a team as a code owner July 24, 2018 18:08
gmmeyer
gmmeyer reviewed Jul 24, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this just never work?

@ofek
Copy link
Contributor Author

ofek commented Jul 24, 2018

That is correct.

@ofek ofek merged commit 945b5e7 into master Jul 24, 2018
@ofek ofek deleted the ofek/proxy branch July 24, 2018 18:42
ofek added a commit that referenced this pull request Jul 24, 2018
@ofek
Properly skip proxy environment variables (#1935)
46817a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @gmmeyer