Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvidia NIM Integration #18964

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Nvidia NIM Integration #18964

wants to merge 11 commits into from
+2,963 −0

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Oct 31, 2024 •
edited
Loading

What does this PR do?

https://datadoghq.atlassian.net/browse/AI-4438

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-agent-integrations-bot datadog-agent-integrations-bot bot added documentation release qa/skip-qa Automatically skip this PR for the next QA labels Oct 31, 2024
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.10345% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.31%. Comparing base (686abf2) to head (6702c3d).
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
nvidia_nim 93.10% <93.10%> (?)
presto ?
slurm ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@Kyle-Neale Kyle-Neale changed the title Create Nvidia NIM scaffolding Nvidia NIM Integration Oct 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

steveny91 and others added 2 commits November 19, 2024 09:28
@steveny91
nvidia dash (#19074)
08738a7 
* nvidia dash

* nits

* more nits

* nit
@Kyle-Neale
validate-assets fixes
af0725a
@Kyle-Neale Kyle-Neale marked this pull request as ready for review November 20, 2024 19:56
@Kyle-Neale Kyle-Neale requested review from a team as code owners November 20, 2024 19:56
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review from a docs team editor label Nov 20, 2024
steveny91
steveny91 reviewed Nov 21, 2024
View reviewed changes
.codecov.yml Outdated Show resolved Hide resolved
steveny91
steveny91 reviewed Nov 21, 2024
View reviewed changes
nvidia_nim/README.md Outdated Show resolved Hide resolved
steveny91
steveny91 reviewed Nov 21, 2024
View reviewed changes
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
steveny91
steveny91 reviewed Nov 21, 2024
View reviewed changes
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
steveny91
steveny91 reviewed Nov 21, 2024
View reviewed changes
nvidia_nim/metadata.csv Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

Assignees
No one assigned
Labels
agent/approved dev/testing dev/tooling docs/review-requested documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor integration/nvidia_nim product/review-requested qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kyle-Neale @steveny91 @jhgilbert