Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax MEMORY_USAGE_THRESHOLD in test to account for slightly increased mem from tracing #18890

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Oct 22, 2024

What does this PR do?

Relax MEMORY_USAGE_THRESHOLD in test to account for slightly increased mem from tracing.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lu-zhengda lu-zhengda changed the title reset peak before trace mem relax MEMORY_USAGE_THRESHOLD in test to account for slightly increased mem from tracing Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@b84e4d8). Learn more about missing BASE report.
Report is 7 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
datadog_checks_base 89.29% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

nenadnoveljic
nenadnoveljic previously approved these changes Oct 23, 2024
@lu-zhengda lu-zhengda added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 43e34f8 Oct 23, 2024
43 of 44 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/reset-peak branch October 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants