Fix sqlserver metric collection row_key #18882
Merged
+2
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update sqlserver metric collection
row_key
to prevent overwriting metric information for two queries with the same query_plan_hash but part of two different stored procedures.Motivation
We noticed that while we separate queries by stored procedure names, the row_key used to aggregate metrics is using
query_plan_hash
. This value can be identical since it's a hash of the plan nodes specific to this query, which can be shared in two different stored procedures. Changing the row_key to use the procedure name should fix this edge case.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged