Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlserver metric collection row_key #18882

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

joelmarcotte
Copy link
Contributor

@joelmarcotte joelmarcotte commented Oct 21, 2024

What does this PR do?

Update sqlserver metric collection row_key to prevent overwriting metric information for two queries with the same query_plan_hash but part of two different stored procedures.

Motivation

We noticed that while we separate queries by stored procedure names, the row_key used to aggregate metrics is using query_plan_hash. This value can be identical since it's a hash of the plan nodes specific to this query, which can be shared in two different stored procedures. Changing the row_key to use the procedure name should fix this edge case.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (d812e0e) to head (62429a9).
Report is 17 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.14% <100.00%> (+11.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nenadnoveljic
Copy link
Contributor

Do we need a changelog entry? We're fixing a bug.

@joelmarcotte joelmarcotte added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 2b35698 Oct 23, 2024
46 of 47 checks passed
@joelmarcotte joelmarcotte deleted the joel.marcotte/fix-sqlserver-metric-group-bys branch October 23, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants