Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sunset Prometheus check #18861

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Sunset Prometheus check #18861

merged 6 commits into from
Oct 21, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Oct 17, 2024 •
edited
Loading

What does this PR do?

Sunset the prometheus check.

Motivation

This check is blocking us from dropping the six dependency from datadog_checks_base. It has also been "legacy" since 2018. It's time.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@iliakur iliakur requested review from a team as code owners October 17, 2024 11:27
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@iliakur iliakur mentioned this pull request Oct 17, 2024
Merged
4 tasks
HadhemiDD
HadhemiDD previously approved these changes Oct 17, 2024
View reviewed changes
HadhemiDD
HadhemiDD previously approved these changes Oct 17, 2024
View reviewed changes
aliciascott
aliciascott approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for docs

@iliakur iliakur added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit 4fb29f2 Oct 21, 2024
51 of 54 checks passed
@iliakur iliakur deleted the ik/AI-4133/sunset-prometheus branch October 21, 2024 09:29
github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
@github-merge-queue
Sunset Prometheus check (#18861)
38e7bd5 
* Sunset Prometheus check

* remove CI config

* no more auto-generated changelog

* trigger agent build

* Revert "trigger agent build"

This reverts commit 7d138f7.

* Improve deprecation notice 4fb29f2
iliakur added a commit that referenced this pull request Oct 24, 2024
@iliakur
Revert "Sunset Prometheus check (#18861)"
a59a5ba 
This reverts commit 4fb29f2.
@iliakur iliakur mentioned this pull request Oct 24, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
@iliakur
Bring back prometheus check and classes (#18907)
007064f 
* Revert "Sunset Prometheus check (#18861)"

This reverts commit 4fb29f2.

* Revert "Remove Prometheus classes and utilities (#18863)"

This reverts commit 1da51b7.
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
@github-merge-queue
Bring back prometheus check and classes (#18907)
bb91d4f 
* Revert "Sunset Prometheus check (#18861)"

This reverts commit 4fb29f2.

* Revert "Remove Prometheus classes and utilities (#18863)"

This reverts commit 1da51b7. 007064f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliciascott aliciascott aliciascott approved these changes

@HadhemiDD HadhemiDD HadhemiDD approved these changes

Assignees
No one assigned
Labels
agent/approved changelog/no-changelog dev/testing dev/tooling docs/approved documentation ecosystems/review-requested integration/prometheus product/review-requested qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iliakur @aliciascott @HadhemiDD