-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunset Prometheus check #18861
Merged
Merged
Sunset Prometheus check #18861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
integration/prometheus
release
qa/skip-qa
Automatically skip this PR for the next QA
team/agent-integrations
team/documentation
labels
Oct 17, 2024
The |
The |
4 tasks
HadhemiDD
previously approved these changes
Oct 17, 2024
This reverts commit 7d138f7.
HadhemiDD
previously approved these changes
Oct 17, 2024
aliciascott
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for docs
HadhemiDD
approved these changes
Oct 21, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agent/approved
changelog/no-changelog
dev/testing
dev/tooling
docs/approved
documentation
ecosystems/review-requested
integration/prometheus
product/review-requested
qa/skip-qa
Automatically skip this PR for the next QA
release
team/agent-integrations
team/documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sunset the prometheus check.
Motivation
This check is blocking us from dropping the
six
dependency fromdatadog_checks_base
. It has also been "legacy" since 2018. It's time.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged