-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-9152] adding more information to kube_api_server check #18822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a small doubt regarding the type of checks that we would like to use for kube_apiserver_metrics
.
- With a service check, all the
apiserver
instances (several different sources) will feed the same timeseries. - With an endpoint check, each
apiserver
instance will have its own timeseries.
I think we want the second type.
At least, that’s what is currently recommended in the check : https://github.com/DataDog/integrations-core/tree/master/kube_apiserver_metrics#configuration
Co-authored-by: JacksonDavenport <[email protected]>
Created DOCS-9275 for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback, but otherwise a great update. Thanks!
Co-authored-by: Rosa Trieu <[email protected]>
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: This merge request was already merged This pull request was merged directly. |
What does this PR do?
Motivation
Support request:
DOCS-9152
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged