Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-9152] adding more information to kube_api_server check #18822

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented Oct 11, 2024

What does this PR do?

Motivation

Support request:
DOCS-9152

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

iliakur
iliakur previously approved these changes Oct 14, 2024
Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a small doubt regarding the type of checks that we would like to use for kube_apiserver_metrics.

  • With a service check, all the apiserver instances (several different sources) will feed the same timeseries.
  • With an endpoint check, each apiserver instance will have its own timeseries.

I think we want the second type.
At least, that’s what is currently recommended in the check : https://github.com/DataDog/integrations-core/tree/master/kube_apiserver_metrics#configuration

kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
@neko-dd
Copy link
Contributor

neko-dd commented Oct 17, 2024

Created DOCS-9275 for review

@neko-dd neko-dd added the editorial review Waiting on a more in-depth review from a docs team editor label Oct 17, 2024
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback, but otherwise a great update. Thanks!

kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
kube_apiserver_metrics/README.md Outdated Show resolved Hide resolved
@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 22, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@aliciascott aliciascott added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit 8a658dc Oct 22, 2024
48 of 49 checks passed
@aliciascott aliciascott deleted the aliciascott/DOCS-9152-kube-api-server branch October 22, 2024 19:59
@dd-devflow
Copy link

dd-devflow bot commented Oct 22, 2024

🚂 MergeQueue: This merge request was already merged

This pull request was merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants