-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly use skip_proxy for instance configuration #1880
Conversation
Let's add tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs change to http_proxy
(at least), which also reads the config. If we're not going to use that, it should be removed (so it's not confusing). And, update the example yamls
) | ||
|
||
if deprecated_skip is not None: | ||
self._log_deprecation('no_proxy') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure that no_proxy
is the one that's intended to be deprecated? My read was that skip_proxy
was the one to be deprecated.
Either way, since the ENV variable is NO_PROXY
, IMO the valid one should be no_proxy
and the deprecated skip_proxy
. They should be the same or it will be more confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually began the deprecation process for no_proxy
a little while back because that and the environment variable NO_PROXY
that the agent also respects mean different things. The env var is a comma separated list of URLs to ignore proxy settings for, but our configuration flag actually semantically meant skip all proxy settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adding tests and a description to the PR. It makes the reviews way easier 💯.
What does this PR do?
Mirrors:
https://github.com/DataDog/dd-agent/blob/2fb88e5b4cbcad950b377ad55bbb4a52ebd4c085/checks/__init__.py#L392
https://github.com/DataDog/datadog-agent/blob/5e22bb6aae27576ed3f7c36f4c7574e487c34348/cmd/agent/dist/checks/__init__.py#L130
Motivation
no_proxy
is deprecated