Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL 8.4 #18571

Merged
merged 6 commits into from
Sep 12, 2024
Merged

MySQL 8.4 #18571

merged 6 commits into from
Sep 12, 2024

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Sep 11, 2024

What does this PR do?

Adds MySQL 8.4 to testing suite and fixes bug in 8.4 due to change from SHOW MASTER STATUS to SHOW BINARY LOG STATUS.

Motivation

MySQL changed the SQL for checking if binlog is enabled in 8.4

Additional Notes

https://datadoghq.atlassian.net/browse/DBMON-4563

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (33559a0) to head (4a8903e).
Report is 11 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 88.64% <100.00%> (+<0.01%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sethsamuel sethsamuel merged commit f70bcfa into master Sep 12, 2024
38 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/mysql-8.4 branch September 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants