-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cilium] Add new metrics with v1.15+ #18406
Merged
steveny91
merged 8 commits into
DataDog:master
from
jaredledvina:jared.ledvina/cilium-v1-15-update
Sep 5, 2024
Merged
[cilium] Add new metrics with v1.15+ #18406
steveny91
merged 8 commits into
DataDog:master
from
jaredledvina:jared.ledvina/cilium-v1-15-update
Sep 5, 2024
+327
−282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
HadhemiDD
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new metrics have to be added for testing too, under tests/fixtures and tests/common.py
steveny91
approved these changes
Sep 5, 2024
Kyle-Neale
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
cilium
integration to include the various new metrics included as of Cilium v1.15.8Motivation
Natively collecting all of the
cilium*
metrics without having to run the OpenMetrics integration.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged