Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cilium] Add new metrics with v1.15+ #18406

Merged

Conversation

jaredledvina
Copy link
Member

@jaredledvina jaredledvina commented Aug 23, 2024

What does this PR do?

This PR updates the cilium integration to include the various new metrics included as of Cilium v1.15.8

Motivation

Natively collecting all of the cilium* metrics without having to run the OpenMetrics integration.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (5798c98) to head (d1e9e86).
Report is 97 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cilium 77.35% <ø> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@HadhemiDD HadhemiDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new metrics have to be added for testing too, under tests/fixtures and tests/common.py

@steveny91 steveny91 merged commit 8beb732 into DataDog:master Sep 5, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants