-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add db util to prepand/append comma delimited SQL comment from key/value pairs #17145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 1 026 files 1 026 suites 6h 35m 21s ⏱️ For more details on these failures, see this check. Results for commit ad6e3a3. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a non-blocking comment
What does this PR do?
This PR adds a db util function
add_sql_comment
to prepand/append comma delimited SQL comment from key/value pairs.Motivation
With
add_sql_comment
, we can start tagging DBM integrations queries generated by the agent. This allows us to build additional filters in DBM to focus on customer queries.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.