Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP authentication #1678

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Add support for HTTP authentication #1678

merged 1 commit into from
Jun 6, 2018

Conversation

rishabh
Copy link

@rishabh rishabh commented Jun 6, 2018

What does this PR do?

This PR adds support for HTTP authentication for mapreduce. This PR also ports over the tests to pytest.

Motivation

Fixes issue where users protect endpoints with authentication.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

@rishabh rishabh added this to the 6.3 milestone Jun 6, 2018
@rishabh rishabh requested a review from a team as a code owner June 6, 2018 00:53
@rishabh rishabh changed the title Add support for HTTPS authentication Add support for HTTP authentication Jun 6, 2018
masci
masci approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's 🚢

@masci masci merged commit c8f5b6d into master Jun 6, 2018
@masci masci deleted the rish/mapreduce-auth branch June 6, 2018 09:11
@rishabh rishabh mentioned this pull request Jun 6, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
integration/mapreduce
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rishabh @masci