Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the direct dependency to protobuf #16572

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 9, 2024

What does this PR do?

Remove the direct dependency to protobuf

Motivation

protobuf is used for the prometheus check and thus should be declared in the base check only. There's no need to duplicate the dependency in other integrations since they depend on the base check.

Additional Notes

I found this trying to bump protobuf, I'll do that in a follow-up PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02c2986) 90.54% compared to head (25ba1e7) 90.64%.
Report is 12 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
gitlab_runner 92.10% <ø> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kube_dns 95.97% <ø> (ø)
kubernetes_state 89.50% <ø> (ø)
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Jan 9, 2024

Test Results

 24 files   24 suites   22m 27s ⏱️
 58 tests  55 ✅   3 💤 0 ❌
280 runs  178 ✅ 102 💤 0 ❌

Results for commit 25ba1e7.

@FlorentClarret FlorentClarret merged commit dbb783d into master Jan 15, 2024
41 of 42 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/remove_protobuf branch January 15, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants