feat(php_fpm): track maximum active processes #16193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
The PHP-FPM status page also provides the "max active processes" statistic, which translates to the maximum number of processes that can be executed at once. In the PHP-FPM configuration, this is controlled by the pm.max_children key. This is particularly useful in understanding saturation within the PHP-FPM container, in a manner that allows horizontal scaling in a more intelligent way than the built-in CPU and memory metrics in Kubernetes. This pairs well with the Datadog External Metrics functionality as well
tcarrio
force-pushed
the
feat/php-fpm-track-max-active-processes
branch
from
f1f538a
to
1fd72da
Compare
FlorentClarret
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Hey 👋
Looks good to me! Would you mind adding a new line to the metadata.csv? Once done, it should be ready to merge.
FlorentClarret
approved these changes
Nov 24, 2023
3 tasks
|
Thank you @FlorentClarret 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PHP-FPM status page also provides the "max active processes" statistic, which translates to the maximum number of processes that can be executed at once. This is particularly useful in understanding saturation within the PHP-FPM container, in a manner that allows horizontal scaling in a more intelligent way than the built-in CPU and memory metrics in Kubernetes. This pairs well with the Datadog External Metrics functionality as well
Motivation
We turned on the External Metrics functionality with Datadog. I wanted to implement saturation-based scaling signals that the Datadog Agent provides through the various
php_fpm.*metrics, but unfortunately there isn't a metric yet for detecting the maximum number of workers yet. So, here it is!Additional Notes
I've been going off of the status pages for our internal PHP-FPM pods, an example of the
/statusoutput:{ "pool": "www", "process manager": "dynamic", "start time": 1699639472, "start since": 8056, "accepted conn": 3006, "listen queue": 0, "max listen queue": 0, "listen queue len": 511, "idle processes": 4, "active processes": 1, "total processes": 5, "max active processes": 9, "max children reached": 0, "slow requests": 0 }I went with
php_fpm.processes.maxbut we could change this tophp_fpm.processes.max_activeto tie it closer to the actual name.Lastly, a support ticket was opened for this feature request
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.