Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CreateContainerConfigError wait reason #16143

Conversation

malmon-circle
Copy link
Contributor

What does this PR do?

This PR adds CreateContainerConfigError to wait reason white list for kubernetes_state

Motivation

We have a need to alert on pods stuck in a CreateContainerConfigError due to missing resources like secrets. This seems to be the only missing reason from kubernetes_state.

Additional Notes

Duplicated efforts from this PR #12758 but for CreateContainerConfigError

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #16143 (5b1edee) into master (e380538) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kubelet 90.97% <ø> (ø)
kubernetes_state 89.18% <100.00%> (ø)
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Nov 2, 2023

Test Results

    6 files      6 suites   1m 0s ⏱️
  84 tests   84 ✔️ 0 💤 0
170 runs  168 ✔️ 2 💤 0

Results for commit 5b1edee.

♻️ This comment has been updated with latest results.

@FlorentClarret
Copy link
Member

Thank you for your contribution!

@FlorentClarret FlorentClarret merged commit 42575d6 into DataDog:master Nov 8, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants