Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set back the timeout option to seconds #16024

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Oct 16, 2023

What does this PR do?

Set back the timeout option to seconds

Motivation

Additional Notes

Relates to https://datadoghq.atlassian.net/browse/AITS-277

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret force-pushed the florentclarret/win32_event_log/fix_timeout branch from 5b7e88f to 2029206 Compare October 16, 2023 15:01
@FlorentClarret FlorentClarret requested a review from a team as a code owner October 16, 2023 15:01
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #16024 (2029206) into master (29b5ea1) will increase coverage by 0.12%.
The diff coverage is n/a.

Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?
win32_event_log 86.98% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

  2 files    2 suites   57s ⏱️
51 tests 51 ✔️ 0 💤 0
71 runs  71 ✔️ 0 💤 0

Results for commit 2029206.

@FlorentClarret FlorentClarret merged commit 6cb07a8 into master Oct 17, 2023
42 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/win32_event_log/fix_timeout branch October 17, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants