Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert psycopg3 upgrade in postgres integration #15859

Merged
merged 24 commits into from
Sep 19, 2023
Merged

Revert psycopg3 upgrade in postgres integration #15859

merged 24 commits into from
Sep 19, 2023

Conversation

alexandre-normand
Copy link
Contributor

@alexandre-normand alexandre-normand commented Sep 18, 2023 •
edited by jmeunier28
Loading

What does this PR do?

This PR reverts the upgrade of psycopg we made in #15411 in order to unblock internal production deploys of the agent. We believe this upgrade is causing blocking in the cluster worker, which is causing other checks to become blocked and not run properly.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited
Loading

Test Results

     12 files       12 suites   16m 34s ⏱️
   227 tests    225 ✔️   2 💤 0 ❌
1 368 runs  1 320 ✔️ 48 💤 0 ❌

Results for commit 940ada8.

♻️ This comment has been updated with latest results.

@alexandre-normand @jmeunier28
Add support for sending database_instance metadata (#15559)
b04fc2d 
* Add support for sending database_instance metadata

* Maybe fix test

* Add changelog

* Update CHANGELOG entry

* Update CHANGELOG entry using ddev tooling

* Fix some tests

* Set expected tags in test

* Fix sneaking typo

* Fix time package usage

* Proper fix for wrong time import

* Fix linting error
@jmeunier28
Add support for authenticating through Azure Managed Identity (#15609)
aa8ad11
@jmeunier28
Fix InstanceConfig loading error for ssl config (#15611)
0863129 
* Fix InstanceConfig loading error

* remove unnecessary ssl defaults

* Set log to be default value for ssl mode

* update changelog
@jmeunier28
Return Azure AD auth token in correct format (#15701)
6b1b4ef 
* Return Azure AD auth token in correct format

* changelog
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@jmeunier28 jmeunier28 changed the title Revert to last good commit Revert psycopg3 upgrade in postgres integration Sep 18, 2023
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ghost ghost added the integration/mysql label Sep 18, 2023
@jmeunier28 jmeunier28 marked this pull request as ready for review September 18, 2023 21:16
@jmeunier28 jmeunier28 requested review from a team as code owners September 18, 2023 21:16
hestonhoffman
hestonhoffman previously approved these changes Sep 18, 2023
View reviewed changes
jmeunier28
jmeunier28 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jmeunier28 jmeunier28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, we should try to schema collection back in & survey anything else other than the upgrade to make sure all expected fixes still get into 7.48

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #15859 (940ada8) into master (e0aa0bd) will increase coverage by 0.09%.
The diff coverage is 92.15%.

Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 91.68% <92.15%> (-0.21%) ⬇️
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@jmeunier28 jmeunier28 merged commit d86a0f0 into master Sep 19, 2023
35 checks passed
@jmeunier28 jmeunier28 deleted the alex.normand/revert-psycopg-upgrade branch September 19, 2023 00:34
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
@jmeunier28
Revert psycopg3 upgrade in postgres integration (#15859) d86a0f0
a672b75
vivek-datadog pushed a commit that referenced this pull request Sep 19, 2023
@alexandre-normand @vivek-datadog
Revert psycopg3 upgrade in postgres integration (#15859)
a532554
@vivek-datadog vivek-datadog mentioned this pull request Sep 19, 2023
Merged
3 tasks
@vivek-datadog vivek-datadog added the category/bugfix For use during Agent Release period label Sep 19, 2023
@iliakur iliakur mentioned this pull request Sep 19, 2023
Merged
3 tasks
@vivek-datadog vivek-datadog mentioned this pull request Sep 19, 2023
Merged
3 tasks
@jmeunier28 jmeunier28 mentioned this pull request Sep 19, 2023
Merged
3 tasks
This was referenced Jan 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeunier28 jmeunier28 jmeunier28 approved these changes

@hestonhoffman hestonhoffman hestonhoffman left review comments

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period documentation integration/mysql integration/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-normand @jmeunier28 @hestonhoffman @vivek-datadog @lu-zhengda