[DBMON-2435] serialize payload with type bytes in json dumps #15763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
lu-zhengda
commented
Sep 5, 2023
| def _hash_to_hex(hash): | ||
| return to_native_string(binascii.hexlify(hash)) | ||
| def _hash_to_hex(hash) -> str: | ||
| return binascii.hexlify(hash).decode("utf-8") |
There was a problem hiding this comment.
to_native_string converts bytes b'xxx' to "b'xxx'". The correct str representation of the hash should be properly decoded.
estherk15
previously approved these changes
Sep 5, 2023
jmeunier28
previously approved these changes
Sep 5, 2023
alexandre-normand
previously approved these changes
Sep 6, 2023
lu-zhengda
dismissed stale reviews from alexandre-normand, jmeunier28, and estherk15
via
c21d6a4
alexandre-normand
previously approved these changes
Sep 7, 2023
FlorentClarret
previously approved these changes
Sep 8, 2023
lu-zhengda
dismissed stale reviews from FlorentClarret and alexandre-normand
via
b80c02e
FlorentClarret
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes JSON serialization bug
TypeError: Type is not JSON serializable: bytesin SQL Server activity collection, which cause the check to abruptly shutdown and restart.Motivation
Fixing a long standing bug reported by customer since v7.37.1 which causes the SQL Server activity collection to shutdown and restart.
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.